Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate info about tokens and certificates #376

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

manuelbuil
Copy link
Contributor

In the Advanced Options section there is information about certificates and tokens which is also in the specific sections for tokens and certificates. I guess that information started in the Advanced Options when there wasn't a specific version for them and then we forgot to remove it

Signed-off-by: manuelbuil <mbuil@suse.com>
Copy link
Member

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its a good idea to have brief info here, and then direct people to the specific CLI pages for details. Maybe we just fix the outdated info in the Token Management section?

@manuelbuil
Copy link
Contributor Author

I think its a good idea to have brief info here, and then direct people to the specific CLI pages for details. Maybe we just fix the outdated info in the Token Management section?

In my opinion, this "advanced options" section became some kind of junk drawer where we put a lot of unconnected stuff. I think we should try to define a bit more what content makes sense here and what content does not. My interpretation was that, as of today, the information we were adding, was important information which did not fit in other sections. Therefore, as certificates and tokens have now their own section, it does not make sense to continue having them here.

However, if we believe we should have a brief info on stuff related to CLI tools in the "advanced options" section, we should also add some lines describing secrets-encrypt and etcd-snapshot, right? Let's talk in SU and see what other think too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants