Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Orientation #55

Closed
Kratsac opened this issue Jul 13, 2016 · 5 comments
Closed

Orientation #55

Kratsac opened this issue Jul 13, 2016 · 5 comments
Assignees
@k3b
Labels
bug mod gallery mod image view
Milestone
0.5.2

Comments

@Kratsac
Copy link

Kratsac commented Jul 13, 2016

Expected behavior

...Display pictures correctly according to their orientation

Actual behavior

Portrait Format is mainly displayed as landscape both in gallery-view as well as in image-view mode.

Environment
@k3b
Copy link
Owner

k3b commented Jul 13, 2016 •
edited
Loading

Thanks for reporting.
Are you shure that you are using the old 0.5.0 version?
Since today the new 0.5.1 version is available on fdroid which has a complete new thumbnail implementation #54 .

@k3b k3b self-assigned this Jul 13, 2016
@k3b k3b added this to the 0.5.2 milestone Jul 13, 2016
@Kratsac
Copy link
Author

Kratsac commented Jul 14, 2016

Somehow, the new version isn't provided via fdriod to me. Don't know why. As soon as I will have tested, I let you know.
Thanks.

@k3b
Copy link
Owner

k3b commented Jul 15, 2016 •
edited
Loading

i have analysed the problem.

  • With version 0.5.0 and below gallery-view-thumbnail and imagedetail-view do not respect exif-orientation. consistent but wrong
  • with 0.5.1 the thumbnail has correct exif-orientation but in imagedetail-view it has not. so with 0.5.1. the problem is more obvious :-)

To fix i have to make changes in in support library

k3b added a commit that referenced this issue Jul 15, 2016
@k3b
#55: fixed orientation problem in imageview. Upgrade to PhotoView:v1.…
4ab3ba1 
…2.6.k3b-5-SNAPSHOT with local PhotoViewEx
@Kratsac
Copy link
Author

Kratsac commented Jul 26, 2016

Checked it with 0.5.1, works fine now. THANKS!

@k3b
Copy link
Owner

k3b commented Jul 26, 2016

thanks for testing. with 0.5.1 galleryview is ok but the detail-view does not respect orientation in 0.5.1. this should be fixed with 0.5.2

@k3b k3b closed this as completed Jul 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@k3b k3b

Labels
bug mod gallery mod image view
Projects
None yet
Milestone
0.5.2
Development

No branches or pull requests
2 participants
@k3b @Kratsac