refactor and pybind of OnlineWebsocketServer #1943
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @csukuangfj ,
I have refactored the previous implementation,
Below code base is functional tested and cleaned up
I think you can suggest more for naming for more clarity
or clean up.
overall summary,
-- refactoring online-websocket-server
-- pybind interface
-- signal termination, graceful shut down
Thanks
closed #1931