-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pybind dependencies from RaggedArc. #842
Merged
Merged
Changes from 9 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
ec3e14d
Convert py::object and torch::IValue to each other
pkufool 30db881
Remove py::object from RaggedAny
pkufool 7f6edc7
Remove py::object from RaggedArc
pkufool 59d1fca
Move files to torch directory
pkufool 80e0460
remove unused files
pkufool 1287173
Add unit tests
pkufool 9046504
Remove v2 folder
pkufool d45707b
Remove unused code
pkufool 793f2de
Remove unused files
pkufool a7a2f93
Fix review comments & fix github actions
pkufool 9dbfc26
Check Ivalue contains RaggedAny
pkufool d3ec095
Minor fixes
pkufool 79a466e
Add attributes related unit test for FsaClass
pkufool 8618ae1
Fix mutable_grad in older pytorch version
pkufool 9a389cb
Fix github actions
pkufool d71c2d0
Fix github action PYTHONPATH
pkufool f44ce30
Fix github action PYTHONPATH
pkufool bcddca7
Link pybind11::embed
pkufool 43641c7
import torch first (to fix macos github actions)
pkufool 0dab860
try to fix macos ci
pkufool File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,7 @@ | ||
add_subdirectory(csrc) | ||
add_subdirectory(python) | ||
if(K2_USE_PYTORCH) | ||
add_subdirectory(torch) | ||
else() | ||
message(FATAL_ERROR "Please select a framework.") | ||
endif() | ||
# add_subdirectory(python) | ||
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.