-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix code style and add copyright. #18
Conversation
The following is how the CI checks the code style and format: icefall/.github/workflows/style_check.yml Lines 46 to 62 in 8469f9a
Could you fix the black version to the one mentioned in icefall/.pre-commit-config.yaml Lines 2 to 6 in 8469f9a
i.e.
https://github.com/k2-fsa/icefall/blob/master/contributing.md |
cnn_module_kernel (int): Kernel size of convolution module | ||
normalize_before (bool): whether to use layer_norm before the first block. | ||
vgg_frontend (bool): whether to use vgg frontend. | ||
num_features (int): Number of input features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you reformat this file by hand or using black
?
I just ran black on this file and nothing is changed.
(I am using black==21.6b0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@csukuangfj I disabled the E501 rule of flake8 for file
egs/librispeech/ASR/conformer_ctc/conformer.py
as it will cut the comments into annoying pieces, especially the example code.