Security group rule #514
Merged
Security group rule #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👀 |
k1LoW
approved these changes
Jun 5, 2020
|
Released as v1.19.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, this adds in extra tests for inbound and outbound rules.... It is currently failing rubocop, because it says the class is too long... it was longer that this, so I'm not sure how to make it much shorter! The only thing I can think of is to remove all the code to check individual ports, because in some senses that's obsolete, now we're testing the actual rules.
But that would break anyone who's using those tests at the moment (not that I think they work properly) - so would welcome suggestions.
thanks
Caroline