Make Emacs respect string delimiter default

[gagbo]

Ref to original PR: eraserhd/parinfer-rust#142

[justinbarclay]

Can you run cargo check --features emacs? I've tried to build this branch, but I am getting a lot of errors.

I fixed up set_option to not error, but I kind of fumbled my way through a few parts just to get the errors to shut up for now.

fn set_option<'a>(
  options: &mut Options,
  option_name: Value<'a>,
  new_value: Value<'a>,
) -> Result<()> {
  let env = option_name.env;
  if option_name.eq(env.intern("partial-result")?) {
    options.partial_result = new_value.is_not_nil();
    return Ok(());
  }
  if option_name.eq(env.intern("force-balance")?) {
    options.force_balance = new_value.is_not_nil();
    return Ok(());
  }
  if option_name.eq(env.intern("return-parens")?) {
    options.return_parens = new_value.is_not_nil();
    return Ok(());
  }
  if option_name.eq(env.intern("comment-char")?) {
    let comment_char: String = new_value.into_rust()?;
    // Not sure if this is good behavior or not, to ignore the empty
    // string and use the default but right now it is just one less
    // error to deal with
    options.comment_char = comment_char.chars().next().unwrap_or_default();
    return Ok(());
  }
  if option_name.eq(env.intern("string-delimiters")?) {
    options.string_delimiters = new_value.into_rust::<Vector>()?
        .into_iter()
        .map(|x| x.into_rust())
        .collect::<Result<Vec<String>>>()?;
    return Ok(());
  }
  if option_name.eq(env.intern("lisp-vline-symbols")?) {
    options.lisp_vline_symbols = new_value.is_not_nil();
    return Ok(());
  }
  if option_name.eq(env.intern("lisp-block-comments")?) {
    options.lisp_block_comments = new_value.is_not_nil();
    return Ok(());
  }
  if option_name.eq(env.intern("guile-block-comments")?) {
    options.guile_block_comments = new_value.is_not_nil();
    return Ok(());
  }
  if option_name.eq(env.intern("scheme-sexp-comments")?) {
    options.scheme_sexp_comments = new_value.is_not_nil();
    return Ok(());
  }
  if option_name.eq(env.intern("julia-long-strings")?) {
    options.janet_long_strings = new_value.is_not_nil();
    return Ok(());
  }
  // I can't get this to work, it looks like you might need to upgrade the emacs crate 17+
  env.signal(unknown_option_error, option_name)
}

[justinbarclay]

On master I just added emacs to the default features in cargo so that cargo and rust-analyzer will pick them up.

[gagbo]

Sure I'll try again, sorry about that, I wonder how so much stuff got outdated, I suppose there’s a new version of the emacs crate

[gagbo]

Should be fine now, ubolonton helped me with my last compilation issue

[justinbarclay]

Thanks for opening this PR :)