Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e test #886

Merged
merged 3 commits into from
Dec 8, 2020
Merged

Fix e2e test #886

merged 3 commits into from
Dec 8, 2020

Conversation

michelherv
Copy link
Contributor

@michelherv michelherv commented Nov 25, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[x] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

image

Some pull requests pipeline fail because the version of Chrome in Xenius is different of the version of Chrome that the protractor's webdriver-manager can load. In this pull request, I make sure that the right webdriver-manager is download before e2e tests running

Issue Number: N/A

Pull request: #879 #880 #881

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Impired by propositions in this issue

@michelherv
Copy link
Contributor Author

Related to #879

Copy link
Owner

@just-jeb just-jeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@just-jeb just-jeb merged commit 42a6395 into just-jeb:master Dec 8, 2020
@just-jeb
Copy link
Owner

just-jeb commented Dec 8, 2020

@all-contributors please add @michelherv for code.

@allcontributors
Copy link
Contributor

@just-jeb

I've put up a pull request to add @michelherv! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants