-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve case for usernames in MWOAuthenticator #168
Comments
@chicocvenancio Which version of JupyterHub and OAuthenticator are you using? This had been addressed in the past for GitHub authentication: #52 Let's first rule out if a version is out of date. |
We're using the 0.6 zero-to-jupyterhub-k8s ( yuvipanda/paws@4d5eeb1 ).
|
Looking at the mediawiki authenticator, I think (not certain) that mediawiki.py may need a mixin like https://github.com/jupyterhub/oauthenticator/blob/master/oauthenticator/github.py#L49 and then have the MWLoginHandler subclass from OAuthLoginHandler. cc/ @minrk |
Defining a custom normalize_username for MW that does something different (e.g. nothing) should work for this. |
Override normalize_username in MWOAuthenticator to allow case to be kept FIX:#168
MediaWiki allows for multiple users with different cases (except for the first letter, Chicocvenancio and chicocvenancio are the same users, but chicocVenancio is a different one).
Should we not preserve the user case from MediaWiki? Maybe we can define normalize_username without lowercasing the username?
See https://phabricator.wikimedia.org/T180336
The text was updated successfully, but these errors were encountered: