Add and document release automation via github actions #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is likely not working any more, as indicated by for exmaple specifying python 3.5 to be used.
consideRatio
commented
Oct 21, 2024
Comment on lines
+27
to
+33
| permissions: | ||
| # id-token=write is required for pypa/gh-action-pypi-publish, and the PyPI | ||
| # project needs to be configured to trust this workflow. | ||
| # | ||
| # ref: https://github.com/jupyterhub/team-compass/issues/648 | ||
| # | ||
| id-token: write |
There was a problem hiding this comment.
@ryanlovett @yuvipanda @minrk could one of you provide this github workflow with the permissions to publish to PyPI?
You'd visit https://pypi.org/manage/project/jupyter-rsession-proxy/settings/publishing/ and under "Add a new publisher" populate 3/4 fields like:
- owner: jupyterhub
- repo: jupyter-rsession-proxy
- workflow name: release.yaml
- environment: leave unspecified
consideRatio
force-pushed
the
pr/release-stuff
branch
from
7d88195 to
9fbe2fd
Compare
ryanlovett
approved these changes
Oct 21, 2024
Comment on lines
+27
to
+33
| permissions: | ||
| # id-token=write is required for pypa/gh-action-pypi-publish, and the PyPI | ||
| # project needs to be configured to trust this workflow. | ||
| # | ||
| # ref: https://github.com/jupyterhub/team-compass/issues/648 | ||
| # | ||
| id-token: write |
|
Thank you @ryanlovett!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had release automation via travis, but it was probably unused as it specified python 3.5 etc. This brings the project up to date with what we find in https://github.com/jupyterhub/jupyterhub-python-repo-template.