Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 10s default timeout and environment varariable #128

Merged
merged 3 commits into from
Sep 2, 2022

Conversation

matuskosut
Copy link
Contributor

@matuskosut matuskosut commented Jun 8, 2022

Increases start timeout from default 5s to 15s, and allows to override using ENV variables (RSERVER_TIMEOUT, RSESSION_TIMEOUT)

  • having longer timeout helps in cases when start is actually slower for any reason

Fixes #127

@welcome
Copy link

welcome bot commented Jun 8, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@matuskosut matuskosut marked this pull request as ready for review June 8, 2022 20:28
@matuskosut
Copy link
Contributor Author

hi @yuvipanda, could you review if this approach makes sense? It's pretty occasional that it takes longer than 5 seconds, but when timeout error appears it is confusing for users, because there is no action out. Having longer timeout reduces this issue significantly. Thanks.

@zeehio
Copy link

zeehio commented Aug 5, 2022

RStudio dumps workspace variables and the list of loaded packages to disk if the session is idle for a long time, and restores them when the user opens it again.

Restoring a large workspace may take a significant amount of time.

In https://docs.rstudio.com/ide/server-pro/access_and_security/running_with_a_proxy.html#check-the-connection-timeout, RStudio recommends a connect timeout of 60 seconds and a read timeout of 20 days.

Some users I worked with, when working with large workspaces (50GB), got timeout errors when restoring the Rastudio session. This is annoying because the running session becomes stuck, and they were unable to save their results after running a long task (that yielded a huge variable). I told them to change their code to avoid this, but still it would be nice to consider larger timeouts (at least 5-10 minutes) for this.

@aaraney
Copy link

aaraney commented Aug 30, 2022

@Castronova and I ran into a similar issue. This PR was able to resolve our use case.

@ryanlovett ryanlovett merged commit 4a794f0 into jupyterhub:master Sep 2, 2022
@welcome
Copy link

welcome bot commented Sep 2, 2022

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@ryanlovett
Copy link
Collaborator

Thanks @matuskosut for the PR, @aaraney and @Castronova for testing, and everyone for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase start timeout
4 participants