Add CHANGELOG.md. #112
Merged
Add CHANGELOG.md. #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuvipanda
reviewed
Dec 1, 2021
CHANGELOG.md
Outdated
| #### Dependency updates | ||
|
|
||
| * Bump jupyter-server-proxy from 3.1.0 to 3.2.0. | ||
| * Remove check for RSESSION_PROXY_RSTUDIO_1_4 environment variable. jupyter-rsession-proxy now supports later versions of rstudio-server 1.4 and the newer date-based releases. For older versions of rstudio-server, please use jupyter-rsession-proxy <= 1.4. |
There was a problem hiding this comment.
Let's pull this out as a BREAKING CHANGE?
There was a problem hiding this comment.
Do you mean isolate it in the changelog in a new section, or actually remove it from the release?
There was a problem hiding this comment.
@ryanlovett I think we should add a new heading to the changelog, as well as make this 2.0 - to make it super clear that you can't just upgrade this package without also upgrading rstudio.
There was a problem hiding this comment.
Updated. How does it look now?
Also bump major version while we're at it.
yuvipanda
approved these changes
Dec 1, 2021
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address #111.