timestamp_format raises an exception #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is allowed to change the timestamp format in nbgrader_config.py. But e.g. c.Exchange.timestamp_format = "%Y-%m-%d-%H-%M-%S-%f" will raise a ValueError('Unknown string format:', '2019-10-24-20-25-53-460007') in dateutil.parser.parse during collect of submissions. This is due to the new dependency of dateutil.parser.parse in parse_utc().
To avoid this during collection of submission, the above code will check the timestamp_format against dateutils parsing algorithm and raises an configuration error.
It is allowed to change the timestamp format in nbgrader_config.py. But e.g. c.Exchange.timestamp_format = "%Y-%m-%d-%H-%M-%S-%f" will raise a ValueError('Unknown string format:', '2019-10-24-20-25-53-460007') in dateutil.parser.parse during collect of submissions. This is due to the new dependency of dateutil.parser.parse in parse_utc().
To avoid this during collection of submission, the above code will check the timestamp_format against dateutils parsing algorithm and raises an configuration error.
…rse " This reverts commit fcbe0d3.
…rse" This reverts commit 1bbf2fe.
ValueError('Unknown string format:', '2019-10-24-20-25-53-460007')
in dateutil.parser.parse during collect of submissions.
This is due to the dependency of dateutil.parser.parse in parse_utc().
To avoid this during collection of submission, this code will
validate the timestamp_format against dateutils parsing algorithm
and raises a TraitError if a ValueError occurs.
|
PR #1245 has to be merged prior to the CI-checks to avoid the build fails in AppVeyor and Travis CI above |
jhamrick
requested changes
Nov 2, 2019
jhamrick
requested changes
Nov 6, 2019
Yes, obviously a typical typo ! Excuse my laxness ! Co-Authored-By: Jessica B. Hamrick <jessica.b.hamrick@gmail.com>
|
Hi Jessica, |
jhamrick
approved these changes
Nov 7, 2019
|
@meeseeksdev backport to 0.6.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/nbgrader
that referenced
this pull request
Nov 7, 2019
jhamrick
added a commit
that referenced
this pull request
Nov 8, 2019
…9-on-0.6.x Backport PR #1249 on branch 0.6.x (timestamp_format raises an exception)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timestamp_format e.g. "%Y-%m-%d-%H-%M-%S-%f" raises an exception ValueError('Unknown string format:', '2019-10-24-20-25-53-460007') in dateutil.parser.parse during collect of submissions. This is due to the dependency of dateutil.parser.parse in parse_utc(). To avoid this during collection of submission, this PR will validate the timestamp_format against dateutils parsing algorithm and raises a TraitError if a ValueError in dateutil.parser.parse occurs.