Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty options #148

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Fix empty options #148

merged 1 commit into from
Nov 2, 2021

Conversation

odow
Copy link
Member

@odow odow commented Nov 2, 2021

From https://discourse.julialang.org/t/amplnlwriter-no-longer-works-with-jump/70740/2

Things were currently working because

julia> options = Dict{String,Any}()
Dict{String, Any}()

julia> [isempty(v) ? k : "$(k)=$(v)" for (k, v) in options]
String[]

But maybe this doesn't hold on every Julia version or machine type. Anyway, we shouldn't be relying on inference to determine this correctly.

Closes #147

@odow odow merged commit 761e54f into master Nov 2, 2021
@odow odow deleted the odow-patch-1 branch November 2, 2021 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Options should be a vector of String
1 participant