Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ FF7 ] Barret's eyebrow not loading #107

Closed
KuraudoXS opened this issue Oct 3, 2020 · 5 comments
Closed

[ FF7 ] Barret's eyebrow not loading #107

KuraudoXS opened this issue Oct 3, 2020 · 5 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@KuraudoXS
Copy link

KuraudoXS commented Oct 3, 2020

Screen Shot 2020-10-04 at 10 07 48 PM
Barret "bad texture" eyebrow PC (8:26): https://youtu.be/vixZODADlPw?t=504

Screen Shot 2020-10-04 at 10 08 14 PM
Barret original eyebrow PSX (57:38): https://youtu.be/yiRgmBpAfNk?t=3454

Could be another "not loaded texture" thing.

@julianxhokaxhiu julianxhokaxhiu added bug Something isn't working help wanted Extra attention is needed labels Oct 3, 2020
@julianxhokaxhiu julianxhokaxhiu added this to the 1.8 milestone Oct 3, 2020
@julianxhokaxhiu julianxhokaxhiu self-assigned this Oct 6, 2020
@julianxhokaxhiu
Copy link
Owner

julianxhokaxhiu commented Oct 6, 2020

It seems the texture is bound correctly, although it's not identical to the one on the PSX. If you want to fix it you'll need to replace it externally.

image

As we can't do much code-wise I'll close this issue :)

Thanks for the report!

@julianxhokaxhiu julianxhokaxhiu added external-fix It needs an external tool to be fixed and removed bug Something isn't working help wanted Extra attention is needed labels Oct 6, 2020
@KuraudoXS
Copy link
Author

It seems the texture is bound correctly, although it's not identical to the one on the PSX. If you want to fix it you'll need to replace it externally.

image

As we can't do much code-wise I'll close this issue :)

Thanks for the report!

No issue. Just want to mention that the texture which is bound correctly might be Cloud's eyebrow.

@julianxhokaxhiu
Copy link
Owner

Maybe it's a bug in the model file?

@Kaldarasha
Copy link

Kaldarasha commented Nov 26, 2020

This is a bug with ff7.exe. Some models, actually every model, which doesn't belong to the main cast, does use Cloud's closed eyes. While that is Barrett in that scene, that model isn't known by the game as main character, so it use Cloud's eyes instead.

@KuraudoXS
Copy link
Author

KuraudoXS commented Sep 26, 2022

@julianxhokaxhiu @tangtang95

After the great achievement by the FFNx team in fixing the Red XIII eye issue. ( dacf5da )
If this is still relevant: I wanted to leave here the last updates.

From the Discord:
vertex2995: "Is that a different model of Barret?"
L@Zar0: "That is the idea. When the game detects the model FQCB, that it assigns the same value as ACGD."
vertex2995: "Then it's probably really easy to fix. Just rewrite that function that returns the eye texture index."
TrueOdin: "I think we'll need to go down that path as well. I'll add the code to replace the call so we can control it
and later extend or fix whatever needs a fix."
vertex2995: "Might be better to just hardcode the strings instead of taking it from ff7.exe. Also the second part (else part) is useless (I think it was for debug mode.)"
TrueOdin: "I'll let you know when I'll get on it."


Here below the known scripted occasions:

  1. Aerith's eye texture 3 used when she is laughing during Cloud's dream after the Temple of Ancients.
  2. Barret's eye texture 4 is used during his flashback in Corel's Prison, when Dyne is falling.
    All other eye textures, which would give a different facial expression for the characters, aren't used.
    The PC version only includes eyes textures 1 and 2, so the scenes above are not displayed properly:
    -In Cloud's dream after the Temple of Ancients, Aerith's eye texture 1 (regular open eyes) is used when she is laughing.
    -In Barret's flashback, oddly enough, Cloud's eye number 2 (closed eyes) is used on Barret's model.

Each playable character also includes two mouth textures (closed and open variations). Only Cid's and Tifa's mouth textures are used in the PlayStation version, and only in two scripted occasions:

  1. Cid's mouth texture 2 (open mouth) is used in the scene where he is with Cloud in Gold Saucer's Round Square.
  2. Tifa's mouth texture 1 (closed mouth) is used when she is talking to Cloud under the Highwind at the end of Disc 2."

Source: https://tcrf.net/Final_Fantasy_VII
Eye Texture picture: https://pbs.twimg.com/media/FYjtVXnWIAEcmt8.png

@julianxhokaxhiu julianxhokaxhiu added bug Something isn't working help wanted Extra attention is needed and removed external-fix It needs an external tool to be fixed labels Sep 27, 2022
@julianxhokaxhiu julianxhokaxhiu removed this from the 1.8 milestone Sep 27, 2022
@julianxhokaxhiu julianxhokaxhiu removed the help wanted Extra attention is needed label Oct 30, 2022
@julianxhokaxhiu julianxhokaxhiu added this to the 1.15.0 milestone Oct 30, 2022
julianxhokaxhiu added a commit that referenced this issue Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants