teamform: Switch to contributte/multiplier #58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
force-pushed
the
contributte-multiplier
branch
from
87ae819 to
726c21e
Compare
jtojnar
force-pushed
the
contributte-multiplier
branch
from
726c21e to
802063d
Compare
`kdyby/replicator` served us well for a long time but unfortunately, it has been unmaintained for a while now. Let’s switch to an actively maintained library. Multiplier manages adding and removing for us and handles default values correctly. The switch also allowed us to remove the outdated explicit anchoring by passing parent and name in constructor, letting Nette handle it. A disadvantage is the inability to access stuff like `htmlId`/`isSubmitted()` without being anchored – but that can be solved by using `monitor()`. Currently, we cannot control per-category person limits at submission.
jtojnar
force-pushed
the
contributte-multiplier
branch
from
802063d to
245302a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kdyby/replicatorserved us well for a long time but unfortunately, it has been unmaintained for a while now. Let’s switch to an actively maintained library.Multiplier manages adding and removing for us and handles default values correctly.
The switch also allowed us to remove the outdated explicit anchoring by passing parent and name in constructor, letting Nette handle it. A disadvantage is the inability to access stuff like
htmlId/isSubmitted()without being anchored – but that can be solved by usingmonitor().Currently, we cannot control per-category person limits at submission: contributte/forms-multiplier#75