Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow slsa spec compliant subjects in provenance #699

Merged
merged 5 commits into from
Aug 26, 2024
Merged

fix: allow slsa spec compliant subjects in provenance #699

merged 5 commits into from
Aug 26, 2024

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Aug 25, 2024 •
edited by lucacasonato
Loading

@littledivy littledivy mentioned this pull request Aug 25, 2024
Merged
@littledivy littledivy changed the title fix(provenance): ensure slsa object spec compliance BREAKING(provenance): ensure slsa object spec compliance Aug 25, 2024
lucacasonato
lucacasonato reviewed Aug 26, 2024
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we just have to ignore incorrectly formatted statements for now rather than erroring. Otherwise this would have to land at the exact same time as the new CLI release going out.

Maybe you can make it an enum that supports both Vec<Subject> and Subject for the moment, and we remove the old one in a month or so?

lucacasonato
lucacasonato approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied the change.

LGTM now

@lucacasonato lucacasonato added this pull request to the merge queue Aug 26, 2024
@lucacasonato lucacasonato removed this pull request from the merge queue due to a manual request Aug 26, 2024
@lucacasonato lucacasonato changed the title BREAKING(provenance): ensure slsa object spec compliance fix: allow slsa spec compliant subjects in provenance Aug 26, 2024
@lucacasonato lucacasonato added this pull request to the merge queue Aug 26, 2024
Merged via the queue into main with commit 0287d69 Aug 26, 2024
8 checks passed
@lucacasonato lucacasonato deleted the fix_provenance_subject branch August 26, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@littledivy @lucacasonato