fix: correctly set the schema ID when passing it as assoc array #769
Conversation
|
@dkarlovi I think this PR could be accepted. If you could just do a rebase and add a changelog entry in Maybe good to know we are seeing multiple issues being reported with associative arrays, which is a concept that doesn't live in JSON. With those two facts we're seeing if we should deprecate the associative array support in the next mayor version |
|
I'm all for deprecating the support as mentioned before. 👍 |
| if (is_object($schema) && property_exists($schema, 'id')) { | ||
| $schemaURI = $schema->id; | ||
| } elseif (is_array($schema) && array_key_exists('id', $schema)) { | ||
| $schemaURI = $schema['id']; | ||
| } else { | ||
| $schemaURI = SchemaStorage::INTERNAL_PROVIDED_SCHEMA_URI; | ||
| } |
There was a problem hiding this comment.
I believe I've learned something more about the codebase today. These changes should be done respecting the CHECK_MODE_TYPE_CAST. Doing either a loose type check or a strict type check. I believe the following would do so (but requires some testing as well)
| if (is_object($schema) && property_exists($schema, 'id')) { | |
| $schemaURI = $schema->id; | |
| } elseif (is_array($schema) && array_key_exists('id', $schema)) { | |
| $schemaURI = $schema['id']; | |
| } else { | |
| $schemaURI = SchemaStorage::INTERNAL_PROVIDED_SCHEMA_URI; | |
| } | |
| $schemaURI = SchemaStorage::INTERNAL_PROVIDED_SCHEMA_URI; | |
| if ($this->factory->getTypeCheck()::propertyExists($schema, 'id')) { | |
| $schemaURI = $this->factory->getTypeCheck()::propertyGet($schema, 'id'); | |
| } |
|
This PR has been replaced by #794 |
Closes #767.