Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Add) 940 cypress ajv validator #941

Merged
merged 7 commits into from
Sep 19, 2024
Merged

(Add) 940 cypress ajv validator #941

merged 7 commits into from
Sep 19, 2024

Conversation

iamAyushChamoli
Copy link
Contributor

What kind of change does this PR introduce?
Adds cypress-ajv-schema-validator

Issue Number:

@iamAyushChamoli iamAyushChamoli requested a review from a team as a code owner September 11, 2024 17:43
Copy link

Hey there 👋!

Are you an implementer of a new JSON Schema related tool, or an interested user submitting a tool you like?
If so, thanks for considering adding your tool to our collection -- and if not, sorry, I'm just a bot looking at which pages you're modifying!

Someone will review your pull request shortly.

In the interim, if you haven't already, there's a few things you might be interested in reviewing or confirming:

  1. Short description: Tell us a small bit about your tool! We love staying up to date on what's out there, and what your intentions are in writing it.
  2. Come Join Our Slack!: We have an #implementers channel for anyone interested in or building JSON Schema tooling!
    An invite can be found here or on our homepage!
  3. Common Interfaces: We maintain a page with some "commonly useful programming interfaces" that tooling may want to implement and present to your users.
    You can find that page here in our documentation.
    Have a read through and consider whether you implement or should implement any of what's there.
  4. Bowtie Harness: Bowtie is a tool which gives JSON Schema users access to a huge number of different implementations across many languages, and reports on the compliance of those implementations with the JSON Schema specifications.
    If it makes sense for your kind of tool, consider writing a harness which connects it to Bowtie. Instructions for doing so can be found in the tutorial in Bowtie's documentation.

If you have any questions, any feedback, or need help with the submission process, don't hesitate to reach out.
Thanks a bunch for your awesome contribution!

Copy link

github-actions bot commented Sep 11, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 7eb4464

@iamAyushChamoli
Copy link
Contributor Author

Need help with finishing up the Tooling Listing Notes because it was way too lengthy as described in #940 . For now, I've selected the shortest of the bullet points mentioned in Tooling Listing Notes in #940 as the placeholder. Please ignore if that gets the job done.

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (33e9315) to head (7eb4464).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #941   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR! much appreciated. Everything looks almost ok but I left 2 small comments.

@iamAyushChamoli
Copy link
Contributor Author

@benjagm Please check if the requested changes were made correctly

@sclavijosuero
Copy link

Hi @benjagm, it seems the only thing pending for the merge to go is for you to approve the changes you requested and already made by @iamAyushChamoli (to add it to util-testing list too)
7eb4464

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thanks

@benjagm benjagm merged commit 21f0874 into json-schema-org:main Sep 19, 2024
10 checks passed
@heysujal
Copy link
Contributor

heysujal commented Oct 1, 2024

@benjagm I used this PR for reference and noticed that it didn't include environments which is mentioned as Cypress in the related issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cypress-ajv-schema-validator
5 participants