-
-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Add) 940 cypress ajv validator #941
(Add) 940 cypress ajv validator #941
Conversation
…o the "Schema to Web UI" Section Fixes #918
Hey there 👋! Are you an implementer of a new JSON Schema related tool, or an interested user submitting a tool you like? Someone will review your pull request shortly. In the interim, if you haven't already, there's a few things you might be interested in reviewing or confirming:
If you have any questions, any feedback, or need help with the submission process, don't hesitate to reach out. |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #941 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 373 373
Branches 94 94
=========================================
Hits 373 373 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this PR! much appreciated. Everything looks almost ok but I left 2 small comments.
As per comment: #941 (comment)
@benjagm Please check if the requested changes were made correctly |
Based on suggestion #941 (comment)
Hi @benjagm, it seems the only thing pending for the merge to go is for you to approve the changes you requested and already made by @iamAyushChamoli (to add it to util-testing list too) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Thanks
@benjagm I used this PR for reference and noticed that it didn't include |
What kind of change does this PR introduce?
Adds
cypress-ajv-schema-validator
Issue Number: