Fixed test cases in additional.json

json-logic · Feb 16, 2025 · b9ac951 · b9ac951
1 parent 505bd00
commit b9ac951
Show file tree

Hide file tree

Showing 9 changed files with 63 additions and 51 deletions.
diff --git a/docs/index.html b/docs/index.html
@@ -31,10 +31,10 @@
     </head>
     <body>
         <h1>JSON Logic Implementation Comparison</h1>
-        <p>Generated on: 2025-02-16 09:50:45</p>
+        <p>Generated on: 2025-02-16 10:00:14</p>
         <table>
     <tr class='header-row'><th rowspan='2'>Test Suite</th><tr class='header-row'><th>jsonlogicnet <i class="devicon-csharp-plain"></i></th><th>DiegoHOliveira <i class="devicon-go-original-wordmark"></i></th><th>HuanTeng <i class="devicon-go-original-wordmark"></i></th><th>jamsesso <i class="devicon-java-plain"></i></th><th>json-logic-engine <i class="devicon-javascript-plain"></i></th><th>jwadhams <i class="devicon-php-plain"></i></th><th>Panzi <i class="devicon-python-plain"></i></th><th>Qubit <i class="devicon-python-plain"></i></th><th>DataLogic <i class="devicon-rust-original"></i></th><th>JsonLogic <i class="devicon-rust-original"></i></th><th>JsonLogicRs <i class="devicon-rust-original"></i></th></tr>
-<tr><td class='left'>additional.json               </td><td class='success-low'>  0/1  </td><td class='success-low'>  0/1  </td><td class='success-low'>  0/1  </td><td class='success-low'>  0/1  </td><td class='success-high'>  4/4  </td><td class='success-medium'>  3/4  </td><td class='success-low'>  0/1  </td><td class='success-low'>  0/1  </td><td class='success-high'>  1/1  </td><td class='success-low'>  0/1  </td><td class='success-low'>  0/1  </td></tr>
+<tr><td class='left'>additional.json               </td><td class='success-low'>  0/4  </td><td class='success-low'>  0/4  </td><td class='success-low'>  0/4  </td><td class='success-low'>  0/4  </td><td class='success-high'>  4/4  </td><td class='success-low'>  0/4  </td><td class='success-low'>  0/4  </td><td class='success-low'>  0/4  </td><td class='success-high'>  4/4  </td><td class='success-low'>  0/4  </td><td class='success-low'>  0/4  </td></tr>
 <tr><td class='left'>arithmetic/divide.extra.json  </td><td class='success-low'>  0/3  </td><td class='success-low'>  0/3  </td><td class='success-low'>  0/3  </td><td class='success-low'>  0/3  </td><td class='success-high'>  3/3  </td><td class='success-low'>  0/3  </td><td class='success-low'>  0/3  </td><td class='success-low'>  0/3  </td><td class='success-high'>  3/3  </td><td class='success-low'>  0/3  </td><td class='success-low'>  0/3  </td></tr>
 <tr><td class='left'>arithmetic/divide.json        </td><td class='success-medium'> 18/31 </td><td class='success-low'> 14/31 </td><td class='success-low'>  5/31 </td><td class='success-low'>  5/31 </td><td class='success-high'> 31/31 </td><td class='success-low'>  6/31 </td><td class='success-low'>  6/31 </td><td class='success-low'>  5/31 </td><td class='success-high'> 31/31 </td><td class='success-medium'> 16/31 </td><td class='success-low'>  5/31 </td></tr>
 <tr><td class='left'>arithmetic/minus.extra.json   </td><td class='success-low'>  0/3  </td><td class='success-low'>  0/3  </td><td class='success-low'>  0/3  </td><td class='success-low'>  0/3  </td><td class='success-high'>  3/3  </td><td class='success-low'>  0/3  </td><td class='success-low'>  0/3  </td><td class='success-low'>  0/3  </td><td class='success-high'>  3/3  </td><td class='success-low'>  0/3  </td><td class='success-low'>  0/3  </td></tr>
@@ -67,8 +67,8 @@ <h1>JSON Logic Implementation Comparison</h1>
 <tr><td class='left'>try.json                      </td><td class='success-low'>  0/18 </td><td class='success-low'>  0/18 </td><td class='success-low'>  0/18 </td><td class='success-low'>  0/18 </td><td class='success-high'> 18/18 </td><td class='success-low'>  0/18 </td><td class='success-low'>  0/18 </td><td class='success-low'>  0/18 </td><td class='success-high'> 18/18 </td><td class='success-low'>  0/18 </td><td class='success-low'>  0/18 </td></tr>
 <tr><td class='left'>val-compat.json               </td><td class='success-low'>  0/60 </td><td class='success-low'>  1/60 </td><td class='success-low'>  0/60 </td><td class='success-low'>  0/60 </td><td class='success-high'> 60/60 </td><td class='success-low'>  0/60 </td><td class='success-low'>  0/60 </td><td class='success-low'>  0/60 </td><td class='success-high'> 60/60 </td><td class='success-low'>  0/60 </td><td class='success-low'>  1/60 </td></tr>
 <tr><td class='left'>val.json                      </td><td class='success-low'>  0/13 </td><td class='success-low'>  0/13 </td><td class='success-low'>  0/13 </td><td class='success-low'>  0/13 </td><td class='success-high'> 13/13 </td><td class='success-low'>  0/13 </td><td class='success-low'>  0/13 </td><td class='success-low'>  0/13 </td><td class='success-high'> 13/13 </td><td class='success-low'>  0/13 </td><td class='success-low'>  0/13 </td></tr>
-<tr class='total-row'><td class='left'>TOTAL                         </td><td class='success-medium'>592/939</td><td class='success-medium'>626/939</td><td class='success-low'>424/939</td><td class='success-medium'>545/939</td><td class='success-high'>942/942</td><td class='success-medium'>620/942</td><td class='success-medium'>612/939</td><td class='success-medium'>587/939</td><td class='success-medium'>935/939</td><td class='success-medium'>623/939</td><td class='success-medium'>606/939</td></tr>
-<tr class='success-row'><td class='left'>Success Rate                  </td><td class=''> 63.05%</td><td class=''> 66.67%</td><td class=''> 45.15%</td><td class=''> 58.04%</td><td class=''>100.00%</td><td class=''> 65.82%</td><td class=''> 65.18%</td><td class=''> 62.51%</td><td class=''> 99.57%</td><td class=''> 66.35%</td><td class=''> 64.54%</td></tr>
+<tr class='total-row'><td class='left'>TOTAL                         </td><td class='success-medium'>592/942</td><td class='success-medium'>626/942</td><td class='success-low'>424/942</td><td class='success-medium'>545/942</td><td class='success-high'>942/942</td><td class='success-medium'>617/942</td><td class='success-medium'>612/942</td><td class='success-medium'>587/942</td><td class='success-medium'>938/942</td><td class='success-medium'>623/942</td><td class='success-medium'>606/942</td></tr>
+<tr class='success-row'><td class='left'>Success Rate                  </td><td class=''> 62.85%</td><td class=''> 66.45%</td><td class=''> 45.01%</td><td class=''> 57.86%</td><td class=''>100.00%</td><td class=''> 65.50%</td><td class=''> 64.97%</td><td class=''> 62.31%</td><td class=''> 99.58%</td><td class=''> 66.14%</td><td class=''> 64.33%</td></tr>
 
         </table>
     </body>

diff --git a/results/csharp.json b/results/csharp.json
@@ -163,7 +163,7 @@
     },
     "additional.json": {
       "jsonlogicnet": {
-        "total": 1,
+        "total": 4,
         "passed": 0,
         "success_rate": 0.0
       }
@@ -234,10 +234,10 @@
   },
   "totals": {
     "jsonlogicnet": {
-      "total": 939,
+      "total": 942,
       "passed": 592,
-      "success_rate": 63.0457933972311
+      "success_rate": 62.84501061571125
     }
   },
-  "timestamp": "2025-02-16T04:20:45.879302Z"
+  "timestamp": "2025-02-16T04:30:14.696609Z"
 }
diff --git a/results/go.json b/results/go.json
@@ -3,11 +3,11 @@
     "additional.json": {
       "DiegoHOliveira": {
         "passed": 0,
-        "total": 1
+        "total": 4
       },
       "HuanTeng": {
         "passed": 0,
-        "total": 1
+        "total": 4
       }
     },
     "arithmetic/divide.extra.json": {
@@ -334,13 +334,13 @@
   "totals": {
     "DiegoHOliveira": {
       "passed": 626,
-      "total": 939
+      "total": 942
     },
     "HuanTeng": {
       "passed": 424,
-      "total": 939
+      "total": 942
     }
   },
-  "timestamp": "2025-02-16T04:20:40Z",
+  "timestamp": "2025-02-16T04:30:07Z",
   "go_version": "go1.23.0"
 }
diff --git a/results/java.json b/results/java.json
@@ -72,7 +72,7 @@
     },
     "additional.json" : {
       "jamsesso" : {
-        "total" : 1,
+        "total" : 4,
         "passed" : 0,
         "success_rate" : 0.0
       }
@@ -234,10 +234,10 @@
   },
   "totals" : {
     "jamsesso" : {
-      "total" : 939,
+      "total" : 942,
       "passed" : 545,
-      "success_rate" : 58.040468583599576
+      "success_rate" : 57.85562632696391
     }
   },
-  "timestamp" : "2025-02-16T04:20:44.939676Z"
+  "timestamp" : "2025-02-16T04:30:12.471864Z"
 }
diff --git a/results/javascript.json b/results/javascript.json
@@ -239,5 +239,5 @@
       "success_rate": 100
     }
   },
-  "timestamp": "2025-02-16T04:20:39.167Z"
+  "timestamp": "2025-02-16T04:30:06.162Z"
 }
diff --git a/results/php.json b/results/php.json
@@ -163,9 +163,9 @@
         },
         "additional.json": {
             "jwadhams": {
-                "passed": 3,
+                "passed": 0,
                 "total": 4,
-                "success_rate": 75
+                "success_rate": 0
             }
         },
         "coalesce.json": {
@@ -234,9 +234,9 @@
     },
     "totals": {
         "jwadhams": {
-            "passed": 620,
+            "passed": 617,
             "total": 942,
-            "success_rate": 65.81740976645435
+            "success_rate": 65.49893842887474
         }
     }
 }
diff --git a/results/python.json b/results/python.json
@@ -233,11 +233,11 @@
     "additional.json": {
       "Qubit": {
         "passed": 0,
-        "total": 1
+        "total": 4
       },
       "Panzi": {
         "passed": 0,
-        "total": 1
+        "total": 4
       }
     },
     "coalesce.json": {
@@ -334,12 +334,12 @@
   "totals": {
     "Qubit": {
       "passed": 587,
-      "total": 939,
+      "total": 942,
       "success_rate": 0
     },
     "Panzi": {
       "passed": 612,
-      "total": 939,
+      "total": 942,
       "success_rate": 0
     }
   }

diff --git a/results/rust.json b/results/rust.json
@@ -2,16 +2,16 @@
   "test_suites": {
     "additional.json": {
       "DataLogic": {
-        "passed": 1,
-        "total": 1
+        "passed": 4,
+        "total": 4
       },
       "JsonLogic": {
         "passed": 0,
-        "total": 1
+        "total": 4
       },
       "JsonLogicRs": {
         "passed": 0,
-        "total": 1
+        "total": 4
       }
     },
     "arithmetic/divide.extra.json": {
@@ -465,16 +465,16 @@
   },
   "totals": {
     "DataLogic": {
-      "passed": 935,
-      "total": 939
+      "passed": 938,
+      "total": 942
     },
     "JsonLogic": {
       "passed": 623,
-      "total": 939
+      "total": 942
     },
     "JsonLogicRs": {
       "passed": 606,
-      "total": 939
+      "total": 942
     }
   }
 }
diff --git a/suites/additional.json b/suites/additional.json
@@ -1,24 +1,26 @@
 [
     "# These are some tests from https://github.com/TotalTechGeek/json-logic-engine/commit/9125e91b5137938a8319de1103b0ebc5819e54e1",
-    [
-        [
+    {
+        "description": "Rule array with val",
+        "rule": [
             1,
             {
                 "val": "x"
             },
             3
         ],
-        {
+        "data": {
             "x": 2
         },
-        [
+        "result": [
             1,
             2,
             3
         ]
-    ],
-    [
-        {
+    },
+    {
+        "description": "If Operator fetching both condition and consequent from data",
+        "rule": {
             "if": [
                 {
                     "val": "x"
@@ -31,16 +33,17 @@
                 99
             ]
         },
-        {
+        "data": {
             "x": true,
             "y": 42
         },
-        [
+        "result": [
             42
         ]
-    ],
-    [
-        {
+    },
+    {
+        "description": "Reduce Operator with val",
+        "rule": {
             "reduce": [
                 {
                     "val": "integers"
@@ -60,7 +63,7 @@
                 }
             ]
         },
-        {
+        "data": {
             "integers": [
                 1,
                 2,
@@ -69,12 +72,21 @@
             ],
             "start_with": 59
         },
-        69
-    ],
+        "result": 69
+    },
     {
         "description": "Simple Inlineable Val Chained",
-        "rule": { "val": { "cat": ["te", "st"] } },
-        "data": { "test": 1 },
+        "rule": {
+            "val": {
+                "cat": [
+                    "te",
+                    "st"
+                ]
+            }
+        },
+        "data": {
+            "test": 1
+        },
         "result": 1
     }
 ]