Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: ability to set non-standard header values #138

Closed
mlucool opened this issue Mar 21, 2022 · 3 comments
Closed

Feature request: ability to set non-standard header values #138

mlucool opened this issue Mar 21, 2022 · 3 comments
Labels
enhancement

Comments

@mlucool
Copy link

mlucool commented Mar 21, 2022

Some browsers accept non-standard cookie headers. Notably, chrome accepts a priority header (issue, code). Would it be possible to extend this package to support setting arbitrary headers?
@dougwilson
Copy link
Contributor

Normally I would lean towards "no", but I mean Google went and made an actual spec for this back in the day (https://datatracker.ietf.org/doc/html/draft-west-cookie-priority-00) and it's been in use for all those years. It seems the browser support has widened in that more browsers are built on Chromium now; even Edge documents the property.

@mlucool
Copy link
Author

mlucool commented Mar 24, 2022

Thanks for the quick turn around!

If anyone ever comes across this, I have also asked Chromium to increase the limit to make this less relevant https://bugs.chromium.org/p/chromium/issues/detail?id=1309656

@dougwilson
Copy link
Contributor

No problem at all. I'll release a new version of this module shortly.

@mlucool mlucool mentioned this issue Apr 14, 2022
Closed
mlucool added a commit to mlucool/session that referenced this issue May 1, 2023
@mlucool
Add cookie.priority
388b99a 
This adds cookie.priority by passing this property through to
cookie (which requires us to upgrade cookie to >=0.5.0).

The priority option is not fully standardized, but has been
proposed and in-use since 2016.

See also: jshttp/cookie#138
Fixes: expressjs#884
@mlucool mlucool mentioned this issue May 1, 2023
Merged
dougwilson pushed a commit to mlucool/session that referenced this issue Dec 12, 2023
@mlucool @dougwilson
Add cookie.priority
0d83077 
This adds cookie.priority by passing this property through to
cookie (which requires us to upgrade cookie to >=0.5.0).

The priority option is not fully standardized, but has been
proposed and in-use since 2016.

See also: jshttp/cookie#138
Fixes: expressjs#884
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dougwilson @mlucool @ejcheng