Skip to content

Commit 0fe05e5

Browse files
authored
Theme: Revert three theme commits that are causing styling issues (#1983)
* Revert "Theme: Removes css for ui-state-checked its not used any more" This reverts commit 1b0e947. * Revert "Theme: Replace missing definition for default icons" This reverts commit dde9b83. * Revert "Theme: Switch icon background to use bgColorContent" This reverts commit 265b8f5. This reverts three commits: * Theme: Removes css for ui-state-checked its not used any more 1b0e947 (#1753) * Theme: Replace missing definition for default icons dde9b83 * Theme: Switch icon background to use bgColorContent 265b8f5 which caused styling issues when compared to UI 1.12.1. This unfixes a few issues: * jquery/download.jqueryui.com#335 * https://bugs.jqueryui.com/ticket/15059 * https://forum.jquery.com/topic/checkboxradio-widget-checkbox-click-doesn-t-work-with-ui-lightness-theme-22-9-2016 However, old & known issues are better than new & unknown ones, especially with our current very limited resources. Closes gh-1983
1 parent 87656cd commit 0fe05e5

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

themes/base/theme.css

+9-5
Original file line numberDiff line numberDiff line change
@@ -116,9 +116,10 @@ a.ui-button:active,
116116
font-weight: normal/*{fwDefault}*/;
117117
color: #ffffff/*{fcActive}*/;
118118
}
119-
.ui-icon-background {
120-
border: #dddddd/*{borderColorContent}*/;
121-
background-color: #ffffff/*{bgColorContent}*/;
119+
.ui-icon-background,
120+
.ui-state-active .ui-icon-background {
121+
border: #003eff/*{borderColorActive}*/;
122+
background-color: #ffffff/*{fcActive}*/;
122123
}
123124
.ui-state-active a,
124125
.ui-state-active a:link,
@@ -136,6 +137,10 @@ a.ui-button:active,
136137
background: #fffa90/*{bgColorHighlight}*/ /*{bgImgUrlHighlight}*/ /*{bgHighlightXPos}*/ /*{bgHighlightYPos}*/ /*{bgHighlightRepeat}*/;
137138
color: #777620/*{fcHighlight}*/;
138139
}
140+
.ui-state-checked {
141+
border: 1px solid #dad55e/*{borderColorHighlight}*/;
142+
background: #fffa90/*{bgColorHighlight}*/;
143+
}
139144
.ui-state-highlight a,
140145
.ui-widget-content .ui-state-highlight a,
141146
.ui-widget-header .ui-state-highlight a {
@@ -214,8 +219,7 @@ a.ui-button:active,
214219
.ui-state-error-text .ui-icon {
215220
background-image: url("images/ui-icons_cc0000_256x240.png")/*{iconsError}*/;
216221
}
217-
.ui-button .ui-icon,
218-
.ui-state-default .ui-icon {
222+
.ui-button .ui-icon {
219223
background-image: url("images/ui-icons_777777_256x240.png")/*{iconsDefault}*/;
220224
}
221225

0 commit comments

Comments
 (0)