Skip to content

Commit 87656cd

Browse files
authored
Theme: Fix blank icons having a background
A fix from 4325446 introduced a rule setting `background-image` of a blank icon to none. However, the selector used for that rule had lower specificity than another one: `.ui-button .ui-icon` which caused dashes being shown over the icons. We needed to increase the specificity of the `.ui-icon-blank` rule past the above selector and past `.ui-button:hover .ui-icon`. We're doing it by repeating the class name three times. Closes gh-1987
1 parent b0ed787 commit 87656cd

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

themes/base/theme.css

+4-1
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,10 @@ a.ui-button:active,
220220
}
221221

222222
/* positioning */
223-
html .ui-icon-blank { background-image: none; }
223+
/* Three classes needed to override `.ui-button:hover .ui-icon` */
224+
.ui-icon-blank.ui-icon-blank.ui-icon-blank {
225+
background-image: none;
226+
}
224227
.ui-icon-caret-1-n { background-position: 0 0; }
225228
.ui-icon-caret-1-ne { background-position: -16px 0; }
226229
.ui-icon-caret-1-e { background-position: -32px 0; }

0 commit comments

Comments
 (0)