Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spacing for pagination dates #26

Merged
merged 2 commits into from
Nov 6, 2021
Merged

Conversation

Benjamin-Lee
Copy link
Contributor

Before and after:

image

With the current styling, I think the spacing is too cramped in the pagination. This PR uses the default margin instead.

@netlify
Copy link

netlify bot commented Nov 6, 2021

✔️ Deploy Preview for hugo-congo ready!
Built without sensitive environment variables

🔨 Explore the source changes: ca3581f

🔍 Inspect the deploy log: https://app.netlify.com/sites/hugo-congo/deploys/6185f8d8682f4f00084fa709

😎 Browse the preview: https://deploy-preview-26--hugo-congo.netlify.app

@jpanther
Copy link
Owner

jpanther commented Nov 6, 2021

Thanks for the PR, @Benjamin-Lee. I think this change is good but might still need a little tweak. I imagine when I styled this I didn't try it out with such long titles and the line height still looks off when it wraps onto multiple lines. I wonder if adding something like leading-5 or leading-6 would help to tighten it up a bit?

A quick mock-up before and after...

Screen Shot 2021-11-06 at 13 38 30

@jpanther jpanther added the bug Something isn't working label Nov 6, 2021
@Benjamin-Lee
Copy link
Contributor Author

Yes, much better with the leading fix. Thanks!

@jpanther jpanther merged commit 5de5c0a into jpanther:dev Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants