Upload Updates (#7)

* Upload overhaul

* Remove unused test

* Add migrations module

* Fix pipeline in insert_variant

* Format

* Credo

* Add test coverage / use ecto multi

* Credo

* Use ACL branch of file_store

* Add postgres service container for tests

* Specify port and user for postgres

* Use MIX_ENV=test for repo config

* Use verbose ecto dropping to figure out what's going on

* Try specifying DB creds

* Fix Dialyzer issues and add missing docs

* Use dev mode for Dialyzer

* Use repo get instead of repo get_by

* Pass through errors from ecto multis

* Add multiple variants to blob variant removal test

* Do not allow keys with periods

* Add tests for multi error cases

* Use Ecto.Query select to only select the variant field

Author: JohnDoneth

.github/workflows/build.yml

@@ -1,5 +1,7 @@
 name: Build
+
 on: [push]
+
 jobs:
   build:
     name: Elixir ${{matrix.elixir}} - OTP ${{matrix.otp}}
@@ -12,16 +14,29 @@ jobs:
     strategy:
       matrix:
         elixir:
-          - "1.12.0"
-          - "1.13.0"
+          - "1.16.1"
         otp:
-          - "24.3.4"
+          - "26.2.2"
 
     services:
       fake-s3:
         image: lphoward/fake-s3
         ports: ["4569:4569"]
 
+      postgres:
+        image: postgres:16
+        ports:
+          - 5432:5432
+        env:
+          POSTGRES_USER: postgres
+          POSTGRES_PASSWORD: postgres
+          POSTGRES_DB: upload_test
+        options: >-
+          --health-cmd pg_isready
+          --health-interval 10s
+          --health-timeout 5s
+          --health-retries 5
+
     steps:
       - name: Checkout
         uses: actions/checkout@v2
@@ -41,6 +56,9 @@ jobs:
       - name: Check formatting
         run: mix format --check-formatted
 
+      - name: Credo
+        run: mix credo
+
       - name: Test
         run: mix test
 
@@ -51,4 +69,4 @@ jobs:
           key: plts-${{ matrix.elixir }}
 
       - name: Dialyzer
-        run: mix dialyzer
+        run: MIX_ENV=dev mix dialyzer

.tool-versions

@@ -1,2 +1,2 @@
-erlang 24.2
-elixir 1.13.2-otp-24
+erlang 26.2.2
+elixir 1.16.1-otp-26

config/config.exs

@@ -1,46 +1,12 @@
 # This file is responsible for configuring your application
 # and its dependencies with the aid of the Mix.Config module.
-use Mix.Config
+import Config
 
-config :upload, Upload, adapter: Upload.Adapters.Test
-config :upload, Upload.Adapters.S3, bucket: "my_bucket_name"
+config :logger, level: :info
 
-# Configuration For AWS
-config :ex_aws,
-  access_key_id: "foo",
-  secret_access_key: "bar"
+# Import environment specific config. This must remain at the bottom
+# of this file so it overrides the configuration defined above.
 
-config :ex_aws, :retries, max_attempts: 1
-
-config :ex_aws, :s3,
-  scheme: "http://",
-  host: "localhost",
-  port: 4569,
-  region: "us-east-1"
-
-# This configuration is loaded before any dependency and is restricted
-# to this project. If another project depends on this project, this
-# file won't be loaded nor affect the parent project. For this reason,
-# if you want to provide default values for your application for
-# 3rd-party users, it should be done in your "mix.exs" file.
-
-# You can configure your application as:
-#
-#     config :upload, key: :value
-#
-# and access this configuration in your application as:
-#
-#     Application.get_env(:upload, :key)
-#
-# You can also configure a 3rd-party app:
-#
-#     config :logger, level: :info
-#
-
-# It is also possible to import configuration files, relative to this
-# directory. For example, you can emulate configuration per environment
-# by uncommenting the line below and defining dev.exs, test.exs and such.
-# Configuration from the imported file will override the ones defined
-# here (which is why it is important to import them last).
-#
-#     import_config "#{Mix.env}.exs"
+if Mix.env() == :test do
+  import_config "#{config_env()}.exs"
+end

config/test.exs

@@ -0,0 +1,28 @@
+import Config
+
+# Configuration for the test suite
+config :upload, ecto_repos: [Upload.Test.Repo]
+
+config :upload, Upload.Test.Repo,
+  adapter: Ecto.Adapters.Postgres,
+  database: "upload_test",
+  pool: Ecto.Adapters.SQL.Sandbox,
+  priv: "test/support/",
+  username: "postgres",
+  password: "postgres",
+  hostname: "localhost"
+
+config :upload, Upload.Test.Vault,
+  ciphers: [
+    default:
+      {Cloak.Ciphers.AES.GCM,
+       tag: "AES.GCM.V1", key: Base.decode64!("KyRFNTop589ClLNsY0fNus68AvWKQfUQMKu5LvS8ToQ=")}
+  ]
+
+config :upload, Upload.Storage,
+  adapter: FileStore.Adapters.Memory,
+  base_url: "http://example.com"
+
+config :upload,
+  repo: Upload.Test.Repo,
+  vault: Upload.Test.Vault