Skip to content

Commit 326b563

Browse files
authored
Allow disabling the virtual host style S3 paths (#6)
1 parent 81614ab commit 326b563

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

lib/upload/adapters/s3.ex

+7-4
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ if Code.ensure_loaded?(ExAws.S3) do
1616
config :upload, Upload.Adapters.S3,
1717
bucket: "mybucket", # required
1818
base_url: "https://mybucket.s3.amazonaws.com" # optional
19+
virtual_host?: true # optional
1920
2021
"""
2122

@@ -43,14 +44,16 @@ if Code.ensure_loaded?(ExAws.S3) do
4344
4445
"""
4546
def base_url do
46-
Config.get(__MODULE__, :base_url, "https://#{bucket()}.s3.amazonaws.com")
47+
if Config.get(__MODULE__, :virtual_host?, true) do
48+
Config.get(__MODULE__, :base_url, "https://#{bucket()}.s3.amazonaws.com")
49+
else
50+
Config.get(__MODULE__, :base_url, "https://s3.amazonaws.com/#{bucket()}")
51+
end
4752
end
4853

4954
@impl true
5055
def get_url(key) do
51-
base_url()
52-
|> URI.merge(key)
53-
|> URI.to_string()
56+
base_url() <> "/" <> key
5457
end
5558

5659
@impl true

0 commit comments

Comments
 (0)