Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TLS Errors on Lambda #921

Merged
merged 3 commits into from
Apr 13, 2021
Merged

Fix TLS Errors on Lambda #921

merged 3 commits into from
Apr 13, 2021

Conversation

freiSMS
Copy link
Contributor

@freiSMS freiSMS commented Apr 13, 2021

Proposed changes

Send data before response + promisify.
Lambda environments skip async sending executions. In the next request the lambda tries to send them again. This can lead to runtime errors or missing data on the dashboard (depending on your lambda settings).

  • improve hint if config is missing

fixes #837

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@aswetlow aswetlow merged commit e91e933 into jovotech:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Analytics Error after sending data
2 participants