Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alexa Event Tracking on Google Analytics wrong pagename fix #918

Merged
merged 2 commits into from
Mar 31, 2021
Merged

Alexa Event Tracking on Google Analytics wrong pagename fix #918

merged 2 commits into from
Mar 31, 2021

Conversation

freiSMS
Copy link
Contributor

@freiSMS freiSMS commented Mar 31, 2021

Proposed changes

The used method $googleAnalytics.sendUserEvent sets the page parameter to the jovo route. For SkillEvent this is not a valid parameter. Used the event method instead.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@aswetlow aswetlow merged commit 89bb3f3 into jovotech:master Mar 31, 2021
@aswetlow
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants