✨ Improve Web-Client browser-detection #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- BrowserDetector uses `detect-browser` to detect the used browser, a wrapper is written around the package to also catch the Brave-browser - SpeechRecognizer now only is supported in Chrome because Chrome is the only browser that has fully implemented SpeechRecognition - Added checks to Client and SpeechRecognizer that checks if it is supported by the current browser - Renamed OSHelper to OSDetector and adjusted logic to work with BrowserDetector
The SpeechRecognition-instance now only gets instantiated when the SpeechRecognizer is supported. This will cause isAvailable to be false and omits redundant code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
detect-browserto detect the used browser, a wrapper is written around the package to also catch the Brave-browserTypes of changes
Checklist