add shared components for login page #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
onkar-josh
commented
May 19, 2020
•
onkar-josh
commented
- I have created shared component for Peerly logo.
- I have written test case for Peerly logo shared component.
3 tasks
onkar-josh
force-pushed
the
feature/react/137/login-page-shared-components
branch
from
cf593d1 to
50faf1c
Compare
mayuriardad
suggested changes
May 21, 2020
react-frontend/src/shared-components/peerly-Logo/LogoComponent.test.js
Outdated
Show resolved
Hide resolved
react-frontend/src/shared-components/peerly-Logo/LogoComponent.js
Outdated
Show resolved
Hide resolved
sahilbhatia
suggested changes
May 25, 2020
| @@ -0,0 +1,28 @@ | |||
| import React from "react"; | |||
| import { Button } from "react-bootstrap"; | |||
There was a problem hiding this comment.
Missing core component wrapper
| @@ -0,0 +1,54 @@ | |||
| import React from "react"; | |||
|
|
|||
| import { Col, Row } from "react-bootstrap"; | |||
There was a problem hiding this comment.
Missing core component wrapper over react-bootstrap component imports
|
|
||
| import LabelComponent from "core-components/Label/LabelComponent"; | ||
|
|
||
| const Logo = Styled.div` |
There was a problem hiding this comment.
React developer guidelines not met. Go through them again.
There was a problem hiding this comment.
@onkar-josh address this comment
There was a problem hiding this comment.
@mayuriardad the folder name of label is changed.
| `; | ||
|
|
||
| const LogoComponent = () => ( | ||
| <Row className="d-flex flex-column" data-testid="peerlyLogoComponent"> |
There was a problem hiding this comment.
Why does a shared component for LogoComponent need Row, Col? Explain the purpose!
onkar-josh
force-pushed
the
feature/react/137/login-page-shared-components
branch
from
a981fbc to
f663a5e
Compare
onkar-josh
removed
the
Changes Requested
mayuriardad
suggested changes
May 25, 2020
| `; | ||
| const PlusSign = Styled.div` | ||
| position: absolute; | ||
| top: 55%; |
There was a problem hiding this comment.
indentation miss
cc: @sahilbhatia
onkar-josh
removed
the
Changes Requested
onkar-josh
force-pushed
the
feature/react/137/login-page-shared-components
branch
from
8ff0195 to
d488cf5
Compare
onkar-josh
force-pushed
the
feature/react/137/login-page-shared-components
branch
from
cf8ea86 to
ff832f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.