-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update webpack5 example to illustrate worker feedback. #456
Conversation
I wanted to add it to PR #455, but couldn't push it to Leonid's branch, and then it was too late :/ |
Thanks @w1nklr, this looks good! I think we should not expand this example further 😅, in general I try to give each example a focus and let it explain 1 thing else you don't see the trees from the forest. One last idea: how about rewriting the example to for rexample React? All the manual management of |
ping @w1nklr |
Sorry, I'm quite busy these times... Just checking I understood it correctly: you want to introduce a dependency in the example on react and rewrite this (and in the end all) example in react. Correct ? |
Yes indeed. But only if you feel like it. We can leave it as it is for now, it was just an idea for further improvement. |
I just updated this one example to react. But build with node (22) fails at test level :( |
Thanks, I'll review the code soon. The node 22 issue is not caused by this PR itself. It seems that there is something changed in the Github Actions or the latest Ubuntu version that it uses, it doesn't support using globals like |
The node 22 issue was introduced in |
Great. |
I've had a look at your latest updates, and this looks really neat! I love that you've split the example in three components, that keeps the example very clear and focused. Thanks! <Fibonacci />
<FibonacciWithFeedback />
<TransferArray /> |
You're welcome. |
As a followup of #439, here comes an example of how to use workerpool.workerEmit() in a browser.
New example (left: before computations, right: with computations):

Enhanced readme to warn that the used
workerpool
package can not be up-to-date and add instructions to install latest package.