Add url dependency for browser compatibility
#28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Nov 21, 2024
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "parse-github-url", | |||
| "name": "isomorphic-parse-github-url", | |||
There was a problem hiding this comment.
this part shouldn’t be in the PR.
| @@ -33,6 +34,9 @@ | |||
| "scripts": { | |||
| "test": "mocha" | |||
| }, | |||
| "dependencies": { | |||
| "url": "^0.11.4" | |||
There was a problem hiding this comment.
this alone doesn’t do anything - requiring “url” always gets the core module, no matter what’s installed.
|
Apologies; I didn't realize that this was still open as a PR. Closing. |
|
@rvanasa i do hope you realize tho that the PR was ineffective, which includes your other package that you published? |
|
Since bundlers often resolve packages differently from Node, the forked version of the library worked as intended. However, in recent versions of Vite, this workaround is no longer necessary. |
|
If a node module bundler does that, then it is broken, full stop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package causes a variety of issues with recent versions of create-react-app and Vite projects due to the need for a polyfill of Node's
urlmodule. This PR adds theurlnpm package as a dependency to make this package work out-of-the-box in the latest version of Webpack and other front-end bundlers.In the meantime, the npm package
isomorphic-parse-github-urlis available as a short-term solution.This change passes all tests and works as expected in a production web application.