Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Classes are not accessible in the namespace package version #11

Closed
derroman opened this issue Feb 26, 2023 · 4 comments · Fixed by #12
Closed

Classes are not accessible in the namespace package version #11

derroman opened this issue Feb 26, 2023 · 4 comments · Fixed by #12
Assignees
@jongpie
Labels
bug Something isn't working namespaced package Issue or enhancement for the namespaced package

Comments

@derroman
Copy link

derroman commented Feb 26, 2023 •
edited
Loading

Hi @jongpie

awesome work! And awesome article about this Cache Manager!! I finally found the time to play around with it and it looks promising! Will definitely include it in existing and new projects.

However I found a little something - or maybe I am just missing something?!

When I install the version without namespace, everything works fine. I can use CacheManager and all of its methods. But when I use the Namespace version instead - it does not work using Nebula namespace. So the classes (and methods?) should be global instead, mh?
@jongpie jongpie added bug Something isn't working namespaced package Issue or enhancement for the namespaced package labels Feb 27, 2023
@jongpie
Copy link
Owner

jongpie commented Feb 27, 2023

@derroman thanks so much for reporting this! This is... an embarrassing issue 😭 You're correct, some of the methods need to be marked as global instead of public - I had made that change several weeks ago while working on the repo, but I never committed the changes. I'll get this fixed for the next release v1.0.3.

@derroman
Copy link
Author

haha, no worries. I was also a little confused. Looking forward for v1.0.3

@jongpie
Copy link
Owner

jongpie commented Feb 27, 2023

Oops, one small correction - the next version will be v1.0.2 (not v1.0.3 - I mistyped the version in my last response). I think I've got most of the changes finished, I'm just working on finishing some testing, and automating the pipeline. I'm hoping to have this released sometime in the next few days.

This was referenced Feb 27, 2023
Merged
Closed
@jongpie jongpie self-assigned this Mar 6, 2023
jongpie added a commit that referenced this issue Mar 6, 2023
@jongpie
Fixed #11 by updating CacheManager.cls to use global on the class, Ca…
fbe540d 
…cheable interface, and several public static methods
jongpie added a commit that referenced this issue Mar 6, 2023
@jongpie
Fixed #11 by updating CacheManager.cls to use global on the class, Ca…
fac9d5b 
…cheable interface, and several public static methods
jongpie added a commit that referenced this issue Mar 6, 2023
@jongpie
Fixed #11 by updating CacheManager.cls to use global on the class, Ca…
e8934c0 
…cheable interface, and several public static methods
jongpie added a commit that referenced this issue Mar 6, 2023
@jongpie
Fixed inaccessible methods in namespaced package (#12)
3dbf694 
* Fixed #11 by updating CacheManager.cls to use global on the top-level class, the Cacheable interface, and several public static methods

* Added pipeline for GitHub Actions

* Added lint-staged.config.js and automated syncing of the version number in several files within the repo/metadata
@jongpie
Copy link
Owner

jongpie commented Mar 6, 2023

@derroman this should be fixed now in the newest release, v1.0.2 🥳 Thanks again for reporting this! Let me know if you run into any other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jongpie jongpie

Labels
bug Something isn't working namespaced package Issue or enhancement for the namespaced package
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed inaccessible methods in namespaced package jongpie/NebulaCacheManager
2 participants
@jongpie @derroman