Feat/update lib #68
Merged
Feat/update lib #68
+100
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so no recovery tests and no using jolo identities this is because of jestjs/jest#4422 which breaks hdkey
mnzaki
force-pushed
the
feat/update_lib
branch
from
ef199d4 to
5d2237c
Compare
Exulansis
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests are failing because the newly added lib
hdkeycalls out tosecp256kand at some point makes a (very sensible) check about it's argument (aBuffer) being aninstanceof Uint8Array, which fails because of jestjs/jest#4422