Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Traditional Chinese (zh-HK) #233

Merged
merged 4 commits into from
Oct 9, 2021
Merged

Add Traditional Chinese (zh-HK) #233

merged 4 commits into from
Oct 9, 2021

Conversation

edwardmfho
Copy link

@edwardmfho edwardmfho commented Oct 9, 2021 •
edited by hugovk
Loading

Changes proposed in this pull request:

  • Adding Traditional Chinese locale into the package.

@edwardmfho edwardmfho changed the title Zh hk locale Adding Traditional Chinese (zh-HK) into the humanize package Oct 9, 2021
@edwardmfho
Copy link
Author

No conflict is found for the script, good to merge.

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2021 •
edited
Loading

Codecov Report

Merging #233 (db5d51f) into master (77a1897) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #233   +/-   ##
=======================================
  Coverage   99.68%   99.68%           
=======================================
  Files           9        9           
  Lines         635      635           
=======================================
  Hits          633      633           
  Misses          2        2
Flag Coverage Δ
GHA_Ubuntu 98.42% <ø> (ø)
GHA_Windows 98.11% <ø> (ø)
GHA_macOS 98.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77a1897...db5d51f. Read the comment docs.

hugovk
hugovk requested changes Oct 9, 2021
View reviewed changes
Copy link
Collaborator

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Please could you check these missing %d, and also the linter check?

@hugovk hugovk added the changelog: Added For new features label Oct 9, 2021
@hugovk hugovk changed the title Adding Traditional Chinese (zh-HK) into the humanize package Add Traditional Chinese (zh-HK) Oct 9, 2021
@edwardmfho
Copy link
Author

Amended the issue with missing %d

@hugovk hugovk added the hacktoberfest-accepted To credit accepted Hacktoberfest PRs label Oct 9, 2021
@edwardmfho
Copy link
Author

Thanks @hugovk for fixing the linter issue - wasn't able to fix it just now was away from keyboard. Thanks!

@hugovk
Copy link
Collaborator

hugovk commented Oct 9, 2021

You're welcome and thank you for the contribution!

@hugovk hugovk merged commit cef8d6e into jmoiron:master Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

Assignees
No one assigned
Labels
changelog: Added For new features hacktoberfest-accepted To credit accepted Hacktoberfest PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edwardmfho @codecov-commenter @hugovk