Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

it appears that we do need to add resources to the image paths from my experience #4

Merged
merged 1 commit into from
Aug 19, 2021
Merged

it appears that we do need to add resources to the image paths from my experience #4

merged 1 commit into from
Aug 19, 2021

Conversation

carriewright11
Copy link
Member

I manually copied files to resources and then then worked for Leanpub. Did not get to test this function though... but easy fix if there is a problem with this

cansavvy
cansavvy approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@cansavvy cansavvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good quick fix but it might be good to investigate if there's a more flexible way to have image paths set/found. I can look into this as I'm playing around with some of this stuff. Will file a PR if I find something.

@carriewright11 carriewright11 merged commit 6c3699c into master Aug 19, 2021
@cansavvy cansavvy deleted the fix_images branch September 28, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cansavvy cansavvy cansavvy approved these changes

@muschellij2 muschellij2 Awaiting requested review from muschellij2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carriewright11 @cansavvy