Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add footnote conversion: take 2 #24

Merged
merged 4 commits into from
Aug 30, 2021
Merged

Conversation

cansavvy
Copy link
Contributor

The sequel to #23

This is working well! I added two functions which do the work and I incorporated it to run with the bookdown_to_leanpub() function.

The footnote looks like:
Screen Shot 2021-08-30 at 12 21 57 PM

Which links you to a page like this:
Screen Shot 2021-08-30 at 12 22 12 PM

I think we may find we need to adjust this as it is used. I mainly made this for my use case while trying to write it guessing about other use cases but ¯_(ツ)_/¯

@cansavvy
Copy link
Contributor Author

This error happens ocassionally and it doesn't have to do with this repository:

The downloaded binary packages are in
	C:\Users\runneradmin\AppData\Local\Temp\Rtmp4Giw5L\downloaded_packages
Error in utils::download.file(url, path, method = method, quiet = quiet,  : 
  cannot open URL 'https://api.github.com/repos/jhudsl/ari/contents/DESCRIPTION?ref=HEAD'
Calls: saveRDS ... github_DESCRIPTION -> download -> base_download -> base_download_headers
Execution halted
Error: Process completed with exit code 1.

@cansavvy
Copy link
Contributor Author

I will re-run the tests later to see if it gets resolved (before this same error was only temporary) Nothing's been happening on https://github.com/jhudsl/ari for awhile, not sure what this is about.

@cansavvy
Copy link
Contributor Author

I filed a separate issue but because that error doesn't have to do with these changes per se, I'm going to go ahead and merge this.

@cansavvy cansavvy merged commit 960f7ce into master Aug 30, 2021
@cansavvy cansavvy deleted the cansavvy/add-foonotes-II branch August 30, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant