Add commas and gha check #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cansavvy
force-pushed
the
cansavvy/add-check
branch
from
35cc540 to
e7f2630
Compare
|
This is working how it should, the only thing that isn't working is that the docker image probably needs a thing updated: jhudsl/OTTR_Template#163 I will check that that is the issue and rerun this later. I think its otherwise ready to go though. |
|
The jhudsl/OTTR_Template#163 error is resolved, now there's a new one that looks file path related: https://github.com/jhudsl/leanbuild/pull/20/checks?check_run_id=3451449028 |
|
It's working and we're all set! Close #13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix this problem: #14 (comment)
If all goes well, this should close #13 and close #17
There were some commas missing in the
build_images()function and I'm adding a new check which checks out the files from https://github.com/jhudsl/DaSL_Course_Template_Leanpub and runs the latest leanbuild changes there.