-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpm conflicts with signal-desktop #259
Comments
First of all I believe #212 is a duplicate of this issue. I know nothing of electron builder but I have seen this issue before in the sphere of Fedora rpmbuild. In those cases one workaround was to add _build_id_links none to the spec file. Are we able to add things to the spec file that electron builder generates? This would completely disable the generation of build ID links, avoiding all conflicts. It's not a long term solution imho. Something fishy is up with the way Electron builder builds a binary because as long as the binary build is unique it should not conflict with any other build. There is more info about it in this bugzilla thread. The issue there seems to have been someone copying a common library, which caused the build IDs to conflict between two packages that used the same copied library file. |
Also I just found this github thread that might cast some light on the situation, if fpm is at all involved. This page says you can specify fpm options to electron builder. |
FYI I've made a poor attempt at doing a PR but I am unfamiliar with Travis build system. I made a small change to the electron build setup to add the necessary fpm argument but my build fails with some sort of token missing. I assume this is set in environment variables or something internal to your Travis build account? For example, apple ID is definitely something I don't have. |
I see conflicts with /usr/lib/.build-id/ links from other software too. Could you please stop adding those /usr/lib/.build-id/ links to the rpm package? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. See the FAQ for more information. |
This commit addresses a certain issue with `rpmbuild` in which certain packages will conflict with each other because they have identical `.build-id` links in the package. I can speculate from some comments I've seen that this might be do to electron versions the packages rely on, but I can't know for sure. Most relevant issues I've seen: jordansissel/fpm#1503 jgraph/drawio-desktop#259
There seems to be a conflict with Bitwarden-2022.8.1-x86_64.rpm as well. sudo dnf -y install Bitwarden-2022.8.1-x86_64.rpm |
There seems to be conflicts also with Slack
as a workaround |
I too got the same error message that @filariow saw. On checking one of those, I could see this:
Thanks for the workaround @filariow! |
Also getting the same issue with slack
|
Same error here with draw.io-20.8.16-1.x86_64 and bitwarden-2023.2.0-1.x86_64. |
Hi, Other conflicting packages include TeamsForLinux. As noted by others before, this can easily be fixed by adding the appropriate fpm options to the electron-builder configuration file ( It's honestly quite frustruating to see this issue is still open after 2 years given jgraph's "Open-source, not open-contribution" policy and the fact that a fix is readily available. I hope someone at jgraph will take the time to review the proposed changes and include a fix in the next release. Regards |
sudo rpm -i ./drawio-x86_64-20.3.0.rpm --excludepath /usr/lib/.build-id/ is a workaround. Should we be running this for anything that conflcits with draw.io? :( |
The "sudo rpm -i --excludepath=/usr/lib/.build-id/ drawio-x86_64-21.1.2.rpm" did not work for me. I was still getting barks about the debug path. "sudo rpm -i --force drawio-x86_64-21.1.2.rpm" worked for me. This thread has a better description: https://unix.stackexchange.com/questions/688839/if-i-do-not-care-about-debug-support-in-red-hat-packages-what-are-the-drawbacks |
This worked for me too. |
Change in 22.0.3 |
When attempting to install the latest rpm on fedora31, I ran into the following issue:
I'm curious what thos .build-id files are, and why they cross conflict. And if there is a way to change the rpm build process to address it. I don't currently see where the rpm is built in the tree, but am happy to look into tweaking that if I can be pointed at it.
The text was updated successfully, but these errors were encountered: