Transfer - Fix phase 3 progressbar #999

yahavi · 2023-10-17T10:47:33Z

All tests passed. If this feature is not already covered by the tests, I added new tests.
All static analysis checks passed.
This pull request is on the dev branch.
I used gofmt for formatting the code before submitting the pull request.

Currently, no one is calling SetTotalSizeAndFilesPhase3. This caused the progress bar to be empty in phase 3.

Before:

After:

github-actions · 2023-10-17T10:50:33Z

artifactory/commands/transferfiles/delayedartifactshandler.go

artifactory/commands/transferfiles/status.go

artifactory/commands/transferfiles/status_test.go

utils/progressbar/transferprogressbarmanager.go

yahavi added the bug Something isn't working label Oct 17, 2023

yahavi requested a review from eyalbe4 October 17, 2023 10:47

yahavi self-assigned this Oct 17, 2023

yahavi temporarily deployed to frogbot October 17, 2023 10:47 — with GitHub Actions Inactive

Transfer - Fix phase 3 progressbar

12593e3

yahavi force-pushed the fix-errors-progress branch from 12a089c to 12593e3 Compare October 17, 2023 11:06

yahavi had a problem deploying to frogbot October 17, 2023 11:06 — with GitHub Actions Failure

eyalbe4 suggested changes Oct 17, 2023

View reviewed changes

CR

cf88797

yahavi had a problem deploying to frogbot October 18, 2023 06:43 — with GitHub Actions Failure

Merge branch 'dev' into fix-errors-progress

7e010f5

yahavi had a problem deploying to frogbot October 18, 2023 06:43 — with GitHub Actions Failure

yahavi merged commit d60d149 into jfrog:dev Oct 18, 2023

yahavi deleted the fix-errors-progress branch October 18, 2023 07:13

chenrui333 mentioned this pull request Oct 18, 2023

jfrog-cli 2.50.2 Homebrew/homebrew-core#151650

Merged

Provide feedback