Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak JAS exclude patterns #1029

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Tweak JAS exclude patterns #1029

merged 1 commit into from
Nov 13, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Nov 13, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Followup #1022

  • .git should be excluded in JAS too
  • In Maven, the target directory should be exactly "target"

@yahavi yahavi added the improvement Automatically generated release notes label Nov 13, 2023
@yahavi yahavi requested review from eyalbe4 and attiasas November 13, 2023 07:14
@yahavi yahavi self-assigned this Nov 13, 2023
@yahavi yahavi merged commit 97009d6 into jfrog:dev Nov 13, 2023
@yahavi yahavi deleted the tweak-exclude-patterns branch November 13, 2023 10:17
gailazar300 pushed a commit to gailazar300/jfrog-cli-core that referenced this pull request Nov 23, 2023
@yahavi @gailazar300
Tweak JAS exclude patterns (jfrog#1029)
5f3b03c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 approved these changes

@attiasas attiasas Awaiting requested review from attiasas

Assignees

@yahavi yahavi

Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yahavi @eyalbe4