Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build append fails with special characters #1020

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Build append fails with special characters #1020

merged 3 commits into from
Nov 9, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Nov 8, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Fix jfrog/jfrog-cli#1803 & jfrog/jfrog-cli#2043
Depends on jfrog/jfrog-client-go#854

@yahavi yahavi force-pushed the build-append-aql2 branch from e529f24 to 27f1ec9 Compare November 8, 2023 10:47
@yahavi yahavi self-assigned this Nov 8, 2023
@yahavi yahavi added the improvement Automatically generated release notes label Nov 8, 2023
@yahavi yahavi requested a review from eyalbe4 November 8, 2023 10:50
@yahavi yahavi marked this pull request as ready for review November 8, 2023 10:51
This was linked to issues Nov 8, 2023
jf rt build-append fails with 404 when looking for a build with ":" in name jfrog/jfrog-cli#1803
Closed
Build aggregation does not work when when trying to aggregate builds that include special characters such as '/' and ':' jfrog/jfrog-cli#2043
Closed
@yahavi yahavi mentioned this pull request Nov 8, 2023
Closed
@yahavi yahavi added bug Something isn't working and removed improvement Automatically generated release notes labels Nov 8, 2023
@yahavi yahavi merged commit 4a64907 into jfrog:dev Nov 9, 2023
@yahavi yahavi deleted the build-append-aql2 branch November 9, 2023 11:09
@BrewTestBot BrewTestBot mentioned this pull request Nov 9, 2023
Merged
@yahavi yahavi mentioned this pull request Nov 19, 2023
Closed
gailazar300 pushed a commit to gailazar300/jfrog-cli-core that referenced this pull request Nov 23, 2023
@yahavi @gailazar300
Build append fails with special characters (jfrog#1020)
2fa6712
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

Assignees

@yahavi yahavi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@yahavi @eyalbe4