Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consolidate status to get rid of shard-specific ones #33

Merged
merged 14 commits into from
Jan 10, 2024
Merged

consolidate status to get rid of shard-specific ones #33

merged 14 commits into from
Jan 10, 2024

Conversation

jflo
Copy link
Owner

@jflo jflo commented Jan 9, 2024

some refactoring during testing releases.

@jflo
consolidate status to get rid of shard-specific ones
24c22b5 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2024

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

jflo added 8 commits January 9, 2024 14:10
@jflo
distracted mid-expression
0a52ace 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
typo in expression
81fd6cc 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
allow pre-review to conclude prior to approval
6af1334 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
conditional should use needs result?
ad5fe6d 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
single quotes?
79856bc 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
i wonder what happens with both success/fail statuses?
3b9b310 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
intentional test failure
c17e28a 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
fix intentional failed test
30dbc09 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
enables status required before merging
a11a939 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
jflo added 4 commits January 10, 2024 12:58
@jflo
default sha not always provided
e6d7a82 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
integration testing required
343aaf0 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
testing default status check behavior with a broken test
26ec5b3 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
testing default status check behavior with corrected test
f6b5e93 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo jflo merged commit 20b3b1e into main Jan 10, 2024
54 checks passed
jflo pushed a commit that referenced this pull request Jan 12, 2024
@fab-10 @macfarla
Make transaction pool configurable in acceptance tests (hyperledger#6380
33df79d 
)

* Make transaction pool configurable in acceptance tests (#33)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

* Make BesuNode::getMiningParameters public

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

---------

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
jflo pushed a commit that referenced this pull request Sep 3, 2024
@fab-10
Make transaction pool configurable in acceptance tests (#33)
dcb6f27 
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fab-10 fab-10 fab-10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jflo @fab-10