Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

versions #21

Merged
merged 20 commits into from
Dec 11, 2023
Merged

versions #21

merged 20 commits into from
Dec 11, 2023

Conversation

jflo
Copy link
Owner

@jflo jflo commented Dec 6, 2023

PR description

Fixed Issue(s)

@jflo
versions
4b54bff 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

jflo added 15 commits December 6, 2023 15:51
@jflo
adds workflow_dispatch
50813a5 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
no uses and run
ca896fe 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
any self-hosted will do for now
ebcd657 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
return of parallel unit tests
88f9238 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
everything is basically documented wrong
b0bf346 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
snake case
87b3963 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
welcome to regex hell
e108e07 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
smaller chunks maybe
3330c23 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
grep gonna grep
7c98a29 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
maybe thats stupid and we can just separate by module
84f05ce 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
definitely don't want to run the whole build
2bd4d33 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
need env arg for matrix val
34bb494 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
env in wrong place
bc9189d 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
lets try acceptance on free runners
af52d39 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
undoes junit deps
9da5006 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
jflo
jflo commented Dec 8, 2023
View reviewed changes
Copy link
Owner Author

@jflo jflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretend LGTM!

jflo added 3 commits December 8, 2023 14:13
@jflo
saw some timeouts, increase runners
73be87d 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
adds tests to separate out long running api tests
af91741 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
ya got me again, spotless
1a27abb 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
garyschulte
garyschulte approved these changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@garyschulte garyschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍿 🚀

.github/workflows/acceptance-tests.yml
name: "Acceptance Runner #${{ matrix.runner-index }}: Run acceptance tests in parallel"
needs:
- runner-indexes
if: ${{ github.actor != 'dependabot[bot]'}}
if: ${{ github.actor != 'dependabot[bot]' && github.event.review.state == 'approved'}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😻

@jflo
push it
2181bf9 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo jflo merged commit b6d2a41 into main Dec 11, 2023
jflo pushed a commit that referenced this pull request Sep 3, 2024
@matkt
add read account into trielog (#21)
456ea00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyschulte garyschulte garyschulte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jflo @garyschulte