-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds a github formatter #463
feat: Adds a github formatter #463
Conversation
Hi, I'm not opposed to the refactoring but can you explain a bit more about what you are trying to accomplish? Is it returning the results in a structure understood by github actions so they appear better in PRs? And then you'll do another PR to implement an action formatter? |
I have the action formatter written already, but I figured doing changes in smaller chunks was a better approach. The link above outlines the format. It allows for inline annotations of the files from the github check run, i believe. |
@isaacsanders Makes sense - I'd say though let's just include it in this PR so that it is a complete feature. |
Added in. Thanks for the review and promptness! |
This all looks pretty good, could I ask you though to also update the mix help & readme docs to document the new "github" option? |
I've added the docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
@isaacsanders I just realized I had to release it to run CI, there are a couple of compile warnings can you please check? |
I've published to hex as 1.2. |
Thanks Jeremy! For this and for being a maintainer! |
I would am working to create a github actions formatter for this library, and the first step I wanted to take is to extract the other formats into modules.