Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set an issue to Unassigned #85

Merged
merged 3 commits into from
Feb 10, 2019
Merged

Set an issue to Unassigned #85

merged 3 commits into from
Feb 10, 2019

Conversation

benjidea
Copy link
Contributor

@benjidea benjidea commented Feb 7, 2019 •
edited by nrayapati
Loading

Allow 'null' as assignee to set the issue to 'unassigned'.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description.
  • Appropriate unit or acceptance tests or explanation to why this change has no tests.
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verified the change matches the issue description.
  • Reviewed the code.
  • Verified that the appropriate tests have been written or valid explanation given.
  • If applicable, tested by installing this plugin on the Jenkins instance.

@nrayapati nrayapati self-requested a review February 7, 2019 23:32
@nrayapati nrayapati self-assigned this Feb 7, 2019
nrayapati
nrayapati requested changes Feb 7, 2019
View reviewed changes
Copy link
Member

@nrayapati nrayapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! and Thank you for the pull request. Please address the comments so that I can get this pulled in.

@benjidea
Copy link
Contributor Author

benjidea commented Feb 8, 2019

Thanks for your review!

@nrayapati nrayapati merged commit a9550e7 into jenkinsci:master Feb 10, 2019
@nrayapati
Copy link
Member

🎉 Thanks a lot for this change @benjidea, I will release it soon after further local testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrayapati nrayapati nrayapati approved these changes

Assignees

@nrayapati nrayapati

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjidea @nrayapati