Fix crash in LocalizerTask #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
| @@ -19,7 +19,7 @@ sourceCompatibility = '1.6' | |||
|
|
|||
| dependencies { | |||
| compile gradleApi() | |||
| compile 'org.jvnet.localizer:maven-localizer-plugin:1.13' | |||
| compile 'org.jvnet.localizer:maven-localizer-plugin:1.12' | |||
There was a problem hiding this comment.
do not downgrade the version, the artifact is in http://repo.jenkins-ci.org/releases/ which is the official repo for all Jenkins related artifacts
|
OK, cool. Gradle 2.13 will provide a better TestKit, which will not require so much boilerplate code. See gradle/gradle@5be4cd0#diff-5c5d96f87fb425d3fe3bc2400a400a4c. But for now, it's OK. Can you squash your commits and force push? |
Add a test to demonstrate a crash in LocalizerTask on projects with multiple modules Update gradle wrapper to 2.8 to be able to use gradleTestKit() Fix crash when org.jvnet.localizer:maven-localizer-plugin is not on the classpath of buildScript (Rewrite LocalizerTask to call GeneratorTaski directly without IsolatedAntBuilder. See JpiLocalizerTaskIntegrationTest."multi-module project should be able to run LocalizerTask"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In gradle a plugin dependency may be declared in one project, but applied in another one.
In this case LocalizerTask may crash, because buildscript may not have
org.jvnet.localizer:maven-localizer-pluginon the classpath.For more information see
JpiLocalizerTaskIntegrationTest.In order to fix the problem I've rewritten
LocalizerTaskto callorg.jvnet.localizer.GeneratorTaskdirectly withoutIsolatedAntBuilder.This PR contains:
org.jvnet.localizer:maven-localizer-pluginversion to 1.12 because 1.13 is not available on maven central.