Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generate-test-hpl task dependency for running tests #125

Merged

Conversation

darxriggs
Copy link

@darxriggs darxriggs commented Jan 1, 2020

This issue was introduced in commit 7a565d3, when lazily registering the task.

Without this fix the build/generated-resources/test/the.hpl is not generated and therefore org.jvnet.hudson.test.PluginAutomaticTestBuilder$OtherTests.testPluginActive from InjectedTest is failing.

@darxriggs
Copy link
Author

A new release containing this fix would be appreciated.

This issue was introduced in commit 7a565d3,
when lazily registering the task.
@darxriggs darxriggs force-pushed the fix-generate-test-hpl-dependency branch from c83c710 to 7854ee0 Compare January 2, 2020 10:13
@sghill sghill merged commit ae67d06 into jenkinsci:master Jan 2, 2020
@darxriggs darxriggs deleted the fix-generate-test-hpl-dependency branch January 2, 2020 20:07
@sghill
Copy link

sghill commented Jan 2, 2020

Thanks for the contribution and finding when it was introduced. This has been released today as v0.36.1.

wolfs added a commit to jenkinsci/gradle-plugin that referenced this pull request Jan 3, 2020
This version contains a bug fix:
jenkinsci/gradle-jpi-plugin#125
@sghill sghill mentioned this pull request Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants