Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use released docker-java version #143

Closed
wants to merge 1 commit into from
Closed

Use released docker-java version #143

wants to merge 1 commit into from

Conversation

guilhem
Copy link
Contributor

@guilhem guilhem commented Jan 22, 2015

/!\ error in build process

/!\ error in build process
@guilhem
Copy link
Contributor Author

guilhem commented Jan 22, 2015

@thomassuckow
Copy link
Contributor

Should probably also think about adding the docker-java snapshot repository to the pom.

@@ -24,9 +24,9 @@

<dependencies>
<dependency>
<groupId>com.nirima.docker-java</groupId>
<groupId>com.github.docker-java</groupId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix seems right

KostyaSha referenced this pull request Jan 23, 2015
Conflicts:
	src/main/java/com/nirima/jenkins/plugins/docker/DockerTemplateBase.java
@imasen
Copy link
Contributor

imasen commented Jan 23, 2015

Could someone upload the jar for the version of @magnayn ? It's hard to develop with red lines in IDE.

@thomassuckow
Copy link
Contributor

His is in OSS

 <repository>
            <id>oss</id>
            <url>http://oss.sonatype.org/content/groups/public/</url>
            <releases>
               <enabled>false</enabled>
            </releases>
            <snapshots>
               <enabled>true</enabled>
            </snapshots>
        </repository>

@magnayn
Copy link
Contributor

magnayn commented Jan 24, 2015

My changes are also in github - I'm slowly sending PRs to docker-java to
try to get back to mainline.

On Fri, Jan 23, 2015 at 9:32 PM, thomassuckow notifications@github.com
wrote:

His is in OSS

oss
http://oss.sonatype.org/content/groups/public/

false

true


Reply to this email directly or view it on GitHub
#143 (comment)
.

@KostyaSha
Copy link
Member

@magnayn please fix master or branch latest released version so people may continue fixing their problems. You can release your any future not tested features as beta release from master then.

@CedricGatay
Copy link

Adding the repository field worked for me to be able to build properly locally.

@magnayn
Copy link
Contributor

magnayn commented Feb 23, 2015

N/A.

We are nearly back to mainline. When that happens we can flip back.

@magnayn magnayn closed this Feb 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants