Skip to content
This repository has been archived by the owner on Apr 25, 2024. It is now read-only.

Add notebook-remove command line option #114

Merged
merged 3 commits into from
Jun 3, 2019
Merged

Add notebook-remove command line option #114

merged 3 commits into from
Jun 3, 2019

Conversation

aiguofer
Copy link

All the code for removing notebooks was there, not sure why the command line option was never actually added.

@jeffkowalski
Copy link
Owner

I think the code was present, but commented-out because it was thought to be too dangerous. Deleting a note at once was OK, but deleting whole notebooks or tags without the ability to undo could cause real stress, and was left to the heavier apps.
Nonetheless, I'll consider merging this code back in.
Caveat emptor ;)

@aiguofer
Copy link
Author

Yeah that makes sense. I think with the built in confirmation this should be a non-issue. I could add something to the prompt indicating that this can't be undone if that would make it more 'user friendly'.

@jeffkowalski jeffkowalski merged commit 94a8aee into jeffkowalski:master Jun 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants